-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve type annotations #244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loads; improve tests
…ct on hydra overloads
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further improves our internal type annotations:
TypeAlias
to make our various aliases explicitPartial
to reflect latest type stub in pyrighthydra_zen.typing._builds_overloads
now exposes protocols instead of overloaded function stubsbuilds
overloads are corrected to eliminate overlapping overload warnings from pyright-strictbuilds
overloads are corrected to provide sufficiently-general annotations; tests includedget_target
andinstantiate
instantiate
builds
now uses the__foo
convention to makehydra_target
positional-onlymake_builds_fn
definition to its own file; simplify overloads; get rid of hacky overload method; enforce pyright-strict(despite these improvements, mypy still crashes when we run on
src/
: python/mypy#12322)