Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to send the productName #24

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

pkern
Copy link
Contributor

@pkern pkern commented Sep 19, 2019

With PSD2 banks now require registration of programs (rather than libraries)
with "Die Deutsche Kreditwirtschaft" on https://www.hbci-zka.de. You are given
a key that needs to be passed in the product name field for access to be
granted. Everyone can apply for this key for their program.

@pkern
Copy link
Contributor Author

pkern commented Sep 19, 2019

I'm not proud of how I did this but at the same time the productName is currently buried fairly deep in the code.

@pkern
Copy link
Contributor Author

pkern commented Sep 21, 2019

FWIW, this got me further with DKB but one also needs to send a HKTAN v6 as part of the dialog initialization so that they let you in - to signal that strong PSD2 auth is supported. I think that's out of scope for this PR, though, and I'll need to find the time for the fix...

@mitch000001
Copy link
Owner

Hey, sorry to come back to you that late. This looks good to me. Actually I would also propagate the product version down that way. And I would not use the defaults go-hbci, as I myself don't have registered yet ;). I'd make them mandatory.

@mitch000001
Copy link
Owner

@pkern I reworked the library to be compliant to PSD2. Also, it contains a working product name now. Can you try it out? You can use https://github.com/mitch000001/go-hbci/releases/tag/v0.4.0-beta.1 to try or just check out the PR #28

With PSD2 banks now require registration of programs (rather than libraries)
with "Die Deutsche Kreditwirtschaft" on https://www.hbci-zka.de. You are given
a key that needs to be passed in the product name field for access to be
granted. Everyone can apply for this key for their program.
@mitch000001 mitch000001 merged commit 61c8b35 into mitch000001:master Mar 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants