Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SWIFT transactions: error unmarshaling MT940 #31

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

Clauscomputing
Copy link
Contributor

Hi,
this fixes

error unmarshaling SWIFT transactions: error unmarshaling MT940: *swift.TransactionTag: Malformed marshaled value

for something like
:61:221214C115,83NMSCNONREF.

According to Gesamtdok_HBCI22.pdf page 753 these values are not mandatory and len(runes) can be 0.

@mitch000001
Copy link
Owner

Can you point out with which bank institute the issue happened? It seems every institute is providing its own flavor of swift implementation.

@Clauscomputing
Copy link
Contributor Author

What do you mean by flavor? Is page 753 not the right spec?

@mitch000001
Copy link
Owner

I guess it is, it just happened to me that some institutes like Sparkasse had a different implementation than implemented here. Therefore I just wanted to document somehow which institute would work for sure with that fix.

@Clauscomputing
Copy link
Contributor Author

Does this fix interfere with with your Sparkasse?

@mitch000001
Copy link
Owner

I tried the code, works just fine.

@mitch000001 mitch000001 merged commit 9e6155f into mitch000001:master Jan 18, 2023
@Clauscomputing
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants