Bump rand to 0.8 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See nannou-org#752 for motivation behind adding a `nannou_core` crate. Note that this commit does not yet replace the color, geom, math and rand modules within the `nannou` crate. This will be performed in a following commit.
This removes the color, math, rand and geom modules in favour of depending on the `nannou_core` crate. The `nannou_core` modules are re-exported within `nannou` in order to provide a near identical API to the existing one. The majority of changes here revolve around the change from `cgmath` to `glam`. The most notable changes include: - `geom::Vector2` -> `glam::Vec2` - `cgmath::Matrix4<f32>` -> `glam::Mat4` - `magnitude` -> `length` This change also removes the generic `Scalar` type parameter from the `Draw` API and related items in the hope of improving downstream compile times. Also removes the seemingly unused `geom::graph` module. Use-cases for this module and its abstractions were mostly made reduntatnt upon allowing for transformations to be applied to the `Draw` instance itself.
This refactors the `Rect` and `Cuboid` methods to try to use `Point*` and `Vec*` types where possible for `Rect<f32>` and `Rect<f64>` in order to maintain an API closer to the original and avoid large sweeps amounts of breaking changes. Also exposes common `glam` types via the `nannou_core` `prelude` module.
mitchmindtree
force-pushed
the
nannou_core
branch
from
f8d3d27 to
3a390da
Compare
|
Nice one! I rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed
glamusesrand 0.8, so bumpedrand 0.7->0.8innannou_coreandnannou_newto avoid one extra dependency.Changes (based on
randupgrade guide):gen_range(a, b) -> gen_range(a..b)stdfeature now also includesrand/std_rng(required to userandom())rand::torandom(), in order to clarify where it comes from (similarly torand::thread_rng()later in the file).SmallRng::from_seed([0; 16])to the recommendedSmallRng::seed_from_u64(0). (This ensures the random seed bits are more evenly balanced between 0s and 1s, which some PRNGs may require.)