Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aTLS support #7

Open
wants to merge 4 commits into
base: old-main
Choose a base branch
from
Open

aTLS support #7

wants to merge 4 commits into from

Conversation

ShannonSD
Copy link
Collaborator

No description provided.

@ShannonSD
Copy link
Collaborator Author

I've added the CA certificate to the quote. Please notice that I still verify the certificates after I set the session.verify attribute, this is because I need to make a request to the server to retrieve a quote and the session needs to be verified by an existing CA bundle or a CA cert we specify to make a request.

This is not a problem because the session is dropped if the quote validation fails, so no requests can be made with that session anyway.

I call the disconnect() method if the validation fails before I raise an error, I do this to reset the session and to delete the client key and certs from the temp files they're stored in. However, disconnect() also destroys the runner and that may be undesirable when an attestation validation fails.

@ShannonSD ShannonSD requested a review from clauverjat August 22, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant