Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Adds string row-wise operations to RemoteLazyFrame #199

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

(feat) Adds string row-wise operations to RemoteLazyFrame #199

wants to merge 23 commits into from

Conversation

kbamponsem
Copy link
Contributor

@kbamponsem kbamponsem commented Jan 19, 2023 •
edited
Loading

This PR adds a few methods on the RemoteLazyFrame and also adds another instruction to the CompositePlan, StringUdfPlanSegement.

The following are the string methods added

contains
match
replace
replace_all
to_uppercase
to_lowercase
fuzzy_match
extract
extract_all
findall
split

Also, unittests are added for all the functions.

@kbamponsem kbamponsem requested a review from dhalf January 19, 2023 13:25
@github-actions
Copy link

github-actions bot commented Jan 19, 2023 •
edited
Loading

☂️ Python Cov

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
382 369 97% 0% 🟢

New Files

File Coverage Status
tests/test_rdf_string_ops.py 99% 🟢
TOTAL 99% 🟢

Modified Files

No covered modified files...

updated for commit: 9ab521b by action🐍

@kbamponsem kbamponsem self-assigned this Jan 19, 2023
@kbamponsem kbamponsem added C-feature Category: Feature A-client Area: Client A-server Area: Server C-docs Category: Documentation labels Jan 20, 2023
@kbamponsem kbamponsem mentioned this pull request Jan 24, 2023
Closed
@kbamponsem
Adds docstring and notebook tutorial
f7b3daf 
Also, it improves test coverage with extract_all

Also fixes issue with '' is not a valid file which wasn't returning the right response.
@kbamponsem
Fix commented sections in notebook and adds more comments to remote_p…
2ddd567 
…olars.py
@dhalf dhalf added P-medium Priority: Medium S-waiting-on-dhalf State: waiting on dhalf to approve or comment labels Jan 26, 2023
dhalf
dhalf suggested changes Jan 26, 2023
View reviewed changes
client/src/bastionlab/polars/remote_polars.py Outdated Show resolved Hide resolved
server/bastionlab_polars/src/utils.rs Outdated Show resolved Hide resolved
@dhalf dhalf added S-waiting-on-opener State: waiting on the person who opened the PR and removed S-waiting-on-dhalf State: waiting on dhalf to approve or comment labels Jan 26, 2023
@kbamponsem kbamponsem requested a review from dhalf January 27, 2023 10:19
dhalf
dhalf suggested changes Jan 31, 2023
View reviewed changes
client/src/bastionlab/polars/remote_polars.py Outdated Show resolved Hide resolved
server/bastionlab_polars/src/composite_plan.rs Outdated Show resolved Hide resolved
server/bastionlab_polars/src/composite_plan.rs Outdated Show resolved Hide resolved
server/bastionlab_polars/src/convert.rs Outdated Show resolved Hide resolved
server/bastionlab_polars/src/errors.rs Outdated Show resolved Hide resolved
server/bastionlab_polars/src/differential_privacy.rs Outdated Show resolved Hide resolved
server/bastionlab_polars/src/init.rs Outdated Show resolved Hide resolved
server/bastionlab_polars/src/visit.rs Outdated Show resolved Hide resolved
@dhalf dhalf added S-blocked State: Blocked and removed S-waiting-on-opener State: waiting on the person who opened the PR labels Feb 3, 2023
@dhalf
Copy link
Contributor

dhalf commented Feb 3, 2023

We are going to rewrite serialization classes with serde, until this is done, this PR is blocked as it involves lots of new such classes

@dhalf dhalf added S-work-in-progress State: Work in progress and removed S-blocked State: Blocked labels Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalf dhalf dhalf requested changes

At least 1 approving review is required to merge this pull request.

Assignees

@kbamponsem kbamponsem

Labels
A-client Area: Client A-server Area: Server C-docs Category: Documentation C-feature Category: Feature P-medium Priority: Medium S-work-in-progress State: Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kbamponsem @dhalf @Knulpinette @ShannonSD @cchudant @lyie28