Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diabetes p1 #234

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

diabetes p1 #234

wants to merge 27 commits into from

Conversation

lyie28
Copy link
Contributor

@lyie28 lyie28 commented Feb 17, 2023

article part 1

dhalf
dhalf suggested changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@dhalf dhalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Explain a bit more what FetchableLazyFrames are at the beginning
  • To select columns with a specific dtype, the Rust API has a dtype function (which returns an expression), I assume there must be a way to do this in Python as well

@dhalf dhalf added P-high Priority: High C-docs Category: Documentation S-waiting-on-Knulpinette State: waiting on Knulpinette to approve or comment A-use-case Area: Use Case labels Feb 21, 2023
@github-actions
Copy link

github-actions bot commented Feb 22, 2023 •
edited
Loading

☂️ Python Cov

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
381 368 97% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: dbefea1 by action🐍

@Knulpinette Knulpinette added S-waiting-on-dhalf State: waiting on dhalf to approve or comment and removed S-waiting-on-Knulpinette State: waiting on Knulpinette to approve or comment labels Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalf dhalf dhalf requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-use-case Area: Use Case C-docs Category: Documentation P-high Priority: High S-waiting-on-dhalf State: waiting on dhalf to approve or comment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyie28 @dhalf @Knulpinette