Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reusable workflows #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tdsmith
Copy link

@tdsmith tdsmith commented Jan 15, 2022

Reusable workflows are a new feature [1] that allow a workflow to be dispatched from another workflow.

Using reusable workflows involves creating a job with a uses key and no steps key [2].

This change allows these jobs to pass silently through actions-includes instead of causing a failure.

[1] https://github.blog/2021-11-29-github-actions-reusable-workflows-is-generally-available/
[2] https://docs.github.com/en/actions/learn-github-actions/reusing-workflows#calling-a-reusable-workflow

Reusable workflows are a new feature [1] that allow a workflow to be
dispatched from another workflow.
Using reusable workflows involves creating a job with a `uses` key and
no `steps` key [2].
This change allows these jobs to pass silently through actions-includes
instead of causing a failure.

[1] https://github.blog/2021-11-29-github-actions-reusable-workflows-is-generally-available/
[2] https://docs.github.com/en/actions/learn-github-actions/reusing-workflows#calling-a-reusable-workflow
Copy link
Owner

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a nice to have a test, but I can merge without it.

@tdsmith
Copy link
Author

tdsmith commented Jan 19, 2022

Thanks! Happy to test this; is a doctest on the changed functions what you're looking for or is there something else that would be useful? I couldn't immediately figure out how the files in /tests are used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants