This repository was archived by the owner on Jun 1, 2018. It is now read-only.
HTTP/2: preparations for pathod #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kriechi
force-pushed
the
http2-wip
branch
2 times, most recently
from
d22b0db to
5af65a3
Compare
| @@ -369,14 +372,14 @@ def finish(self): | |||
| """ | |||
|
|
|||
| def _create_ssl_context(self, | |||
| method=SSLv23_METHOD, | |||
| method=TLSv1_2_METHOD, | |||
There was a problem hiding this comment.
That shouldn't be required?
SSLv23_METHOD + OP_NO_SSLv2 | OP_NO_SSLv3 == TLS 1.0+, which is what we want to keep for now.
There was a problem hiding this comment.
This also causes an issue with OpenSSL compatibility. TLS 1.2 was introduced in OpenSSL 1.0.1 (iirc). The default version on OSX 10.10.3 is is 0.9.8, so this will fail. I suggest we check what's supported on import and pick the best default to use.
|
Good stuff 👍 . Apart from the comment above, LGTM. |
cortesi
added a commit
that referenced
this pull request
Jun 14, 2015
HTTP/2: preparations for pathod
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new methods for the upcoming Pathoc & Pathod integration.