fix #490

CHANGELOG.md

@@ -6,6 +6,8 @@
 
  - Switch from `setup.py` to `pyproject.toml` for pdoc itself. Please file an issue if that causes any problems. 
    ([#474](https://github.com/mitmproxy/pdoc/issues/474), @mhils)
+ - Fix broken links for inherited methods if both parent and subclass have the same name.
+   ([#493](https://github.com/mitmproxy/pdoc/pull/493), @mhils) 
 
 ## 2022-11-15: pdoc 12.3.0
 

pdoc/render_helpers.py

@@ -369,8 +369,18 @@ def link(context: Context, spec: tuple[str, str], text: str | None = None) -> st
     modulename, qualname = spec
 
     # Check if the object we are interested is also imported and re-exposed in the current namespace.
-    doc = mod.get(qualname)
-    if doc and doc.taken_from == spec and context["is_public"](doc).strip():
+    # https://github.com/mitmproxy/pdoc/issues/490: We need to do this for every level, not just the tail.
+    doc: pdoc.doc.Doc | None = mod
+    for part in qualname.split("."):
+        doc = doc.get(part) if isinstance(doc, pdoc.doc.Namespace) else None
+        if not (
+            doc
+            and doc.taken_from[0] == modulename
+            and context["is_public"](doc).strip()
+        ):
+            break
+    else:
+        # everything down to the tail is imported and re-exposed.
         if text:
             text = text.replace(f"{modulename}.", f"{mod.modulename}.")
         modulename = mod.modulename