Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nav horizontal scroll z-index #616

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Fix nav horizontal scroll z-index #616

merged 3 commits into from
Sep 4, 2023

Conversation

Domi04151309
Copy link
Contributor

Description

When embedding content within a page, such as an SVG graphic, with a width exceeding 100%, the vertical scrolling behavior results in an unintended overlay with the menu.

Fix

Add z-index: 1 to the nav element.

Before

without

After

with

@mhils
Copy link
Member

mhils commented Sep 4, 2023

Thanks! 🍰

Could you please add a changelog entry? Otherwise this looks good to merge! 😃

@mhils mhils enabled auto-merge (squash) September 4, 2023 21:49
mhils
mhils approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@mhils mhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@mhils mhils merged commit c1ddd1e into mitmproxy:main Sep 4, 2023
12 checks passed
@Domi04151309 Domi04151309 deleted the scroll-bug branch September 4, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhils mhils mhils approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Domi04151309 @mhils