-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce @public marker to explicitly mark members as public #655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you so much for tackling this! 🍰
test/testdata/visibility.py
Outdated
|
||
def yet_another_func(): | ||
""" | ||
This is yet another public method to give a gauge for the expected amount of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I don't fully understand why there is a second public method here. What are we verifying with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to see if there is any unwanted whitespace after the docstring in the generated html. The second method is there only to see how much spacing between methods you get regularly. For the automated test suite it's probably not really useful.
Also sorry @public for the notifications! ❤️ Looks like you're taking this with a bit of humor, which is great. Thank you for your understanding, I'll try to go with |
I'm used to it :) |
Co-authored-by: Maximilian Hils <git@maximilianhils.com>
Co-authored-by: Maximilian Hils <git@maximilianhils.com>
Co-authored-by: Maximilian Hils <git@maximilianhils.com>
Co-authored-by: Maximilian Hils <git@maximilianhils.com>
Co-authored-by: tmeyier <95271082+tmeyier@users.noreply.github.com>
The code review functionality in github still is a bit confusing for me. Sorry for the git mess. |
No worries at all, we'll squash anyways. Thanks again for contributing this, this is really cool! 😃 🍰 |
Here is an implementation of the @public marker, as proposed in #646.
__doc__
has higher precedence than @publiccloses #645