Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xblock 2.0 support #359

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Add xblock 2.0 support #359

merged 1 commit into from
Apr 1, 2024

Conversation

irtazaakram
Copy link

@Anas12091101
Copy link

Anas12091101 commented Mar 29, 2024

@irtazaakram, based on my initial understanding, it seems that in the test_export test case, this line is being called in the edx-platform, which is removing the xblock-family attribute, leading to the assertion error. In the test_import test case, the line is invoking the parse_xml method of edx-sga with the id-generator, causing the error.

@irtazaakram
Copy link
Author

Thanks for looking into this @Anas12091101. Seems like a circular dependency. We are updating xblock https://github.com/openedx/edx-platform/pull/34398/files#diff-f82cb2116924880209a8846a4a84aee3f70301cb682fed8e05a987103da61c9a here that depends on this change here.

What are our options here

@Anas12091101 Anas12091101 self-assigned this Mar 29, 2024
@Anas12091101
Copy link

@irtazaakram I have tested it locally. LGTM. Can you tell me how long is it expected to merge your edx-platform PR?

Copy link

@Anas12091101 Anas12091101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing but this is required as per @irtazaakram because they need a new release

@irtazaakram
Copy link
Author

@Anas12091101 PR should be merged as early as possible. I'll let you know as soon its ready.

@Anas12091101 Anas12091101 merged commit bdbed63 into mitodl:master Apr 1, 2024
0 of 2 checks passed
@odlbot odlbot mentioned this pull request Apr 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants