Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No audit grades in program records #1747

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

annagav
Copy link
Contributor

@annagav annagav commented Jul 13, 2023

What are the relevant tickets?

Fix #1742

Description (What does it do?)

This PR filter only grades earned in a verified more of enrollment for display on the Learner Records page.

How can this be tested?

  1. create a course run grade for your user
  2. create a verified enrollment for that course run
  3. view Program records, the grade should show
  4. then set the enrollment to audit
  5. Check the Program Records again, now the grade should not be there

@pdpinch
Copy link
Member

pdpinch commented Jul 14, 2023

I'd like to check with a couple of folks before this is merged.

@jkachel jkachel self-assigned this Jul 14, 2023
@jkachel
Copy link
Contributor

jkachel commented Jul 14, 2023

I tested this with a set of enrollments that resulted in certificates being generated. When I set one of them to audit, it still shows that I have a certificate for the course. Should this be the case or should the certificate flag be hidden if there's not a verified enrollment for the user?

Functionality regarding the program completion badge and the grade display works as expected.

@pdpinch
Copy link
Member

pdpinch commented Jul 17, 2023

should the certificate flag be hidden if there's not a verified enrollment for the user?

We already have a mechanism for revoking certificates. Additional logic to hide a certificate in a degenerate state like this (and a test for that logic) adds unneeded complexity.

@annagav
Copy link
Contributor Author

annagav commented Jul 18, 2023

@pdpinch I think what James was asking is - if a learner doesn't have a verified enrollment should the certificate be not shown on their dashboard or revoked?

My answer would be we leave the certificate as is even if the enrollment mode changes for the user.

@annagav annagav requested a review from jkachel July 18, 2023 11:44
Copy link
Contributor

@jkachel jkachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@annagav annagav merged commit d8b2172 into main Jul 18, 2023
3 checks passed
@annagav annagav deleted the ag/records_showing_audit_grades branch July 18, 2023 20:11
@odlbot odlbot mentioned this pull request Jul 20, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Program records are showing a grade for audited course run
3 participants