Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove EdX-Api-Key usage #2982

Merged
merged 4 commits into from
May 24, 2024

Conversation

mudassir-hafeez
Copy link
Contributor

@mudassir-hafeez mudassir-hafeez commented May 14, 2024

What are the relevant tickets?

#2872

Description (What does it do?)

This PR removes EDX_API_KEY usage as Open edX is going to remove the EDX_API_KEY. Details can be found at openedx/edx-platform#34039.

Screenshots (if appropriate):

  • Desktop screenshots
  • Mobile width screenshots

How can this be tested?

  • Fetch and check out to this branch, and check that edX is configured properly.
  • Test all the endpoints that currently utilize EdX-Api-Key for client requests, or follow the testing instructions mentioned in refactor: remove X-EdX-Api-Key usage edx-api-client#104. It's important to thoroughly test all the instructions provided in this PR.

Additional Context

Copy link

gitguardian bot commented May 14, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@mudassir-hafeez mudassir-hafeez force-pushed the mudassir/remove-edx-api-key-usage branch from f4708aa to 428d062 Compare May 14, 2024 06:13
@mudassir-hafeez mudassir-hafeez force-pushed the mudassir/remove-edx-api-key-usage branch from 6e17d02 to d2affc3 Compare May 14, 2024 09:57
@mudassir-hafeez mudassir-hafeez marked this pull request as ready for review May 14, 2024 13:01
@mudassir-hafeez mudassir-hafeez force-pushed the mudassir/remove-edx-api-key-usage branch from ce2ecc8 to 243d45d Compare May 16, 2024 18:07
@mudassir-hafeez mudassir-hafeez force-pushed the mudassir/remove-edx-api-key-usage branch from 0391589 to d3b8678 Compare May 16, 2024 18:21
@mudassir-hafeez mudassir-hafeez removed the request for review from asadali145 May 17, 2024 13:03
@asadali145 asadali145 self-assigned this May 20, 2024
Copy link
Contributor

@asadali145 asadali145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We need to merge mitodl/edx-api-client#104 and release the edx-api-client and then update this xPro PR with the new version of edx-api-client.

@asadali145
Copy link
Contributor

@mudassir-hafeez there is conflict. Could you resolve?

@mudassir-hafeez mudassir-hafeez force-pushed the mudassir/remove-edx-api-key-usage branch from 44ed4f9 to 2ff6c4d Compare May 22, 2024 09:32
@mudassir-hafeez
Copy link
Contributor Author

@asadali145 can you please re-review as the conflict is resolved? also bumped edx-api-client version to 1.9.0 as it was published to PYPI.

Copy link
Contributor

@asadali145 asadali145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants