Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "name" field from the metadata of stories in WebsiteContent #2373

Merged

Conversation

ibrahimjaved12
Copy link
Contributor

What are the relevant tickets?

Part of https://github.com/mitodl/hq/issues/6320

Description (What does it do?)

This PR introduces a manual migration to remove the name field from the metadata of stories in the WebsiteContent model.

How can this be tested?

Checkout to this branch, spin up OCW Studio locally, jump into the Web container in Docker and run: python manage.py migrate. Make sure name is no longer present in metadata.

Copy link
Contributor

@umar8hassan umar8hassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibrahimjaved12, the migration works but we should include an empty rollback with a warning message just in case.

Copy link
Contributor

@umar8hassan umar8hassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@ibrahimjaved12 ibrahimjaved12 merged commit fc8fdc4 into master Jan 7, 2025
7 checks passed
@ibrahimjaved12 ibrahimjaved12 deleted the ibrahim/6320-remove-name-field-from-stories-metadata branch January 7, 2025 13:22
@odlbot odlbot mentioned this pull request Jan 7, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants