Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create transcoding App #183

Merged
merged 23 commits into from
Feb 21, 2025
Merged

Conversation

umar8hassan
Copy link
Contributor

@umar8hassan umar8hassan commented Feb 19, 2025

What are the relevant tickets?

fixes https://github.com/mitodl/hq/issues/6717

Description (What does it do?)

Added a transcoding app for media convert tasks with AWS

How can this be tested?

This will be tested alongwith mitodl/ocw-studio#2421 after publish

@umar8hassan umar8hassan force-pushed the umar/6717-refactor-transcoding-job-code branch from 9cd2091 to 3aace8e Compare February 20, 2025 13:49
@umar8hassan umar8hassan marked this pull request as ready for review February 21, 2025 14:11
Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor things

Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are all minor nitpicks and the PR is blocking OVS updates, approving it. The suggestions can be implemented in a subsequent PR

@umar8hassan umar8hassan merged commit 4ce05d1 into main Feb 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants