Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Theme #71

Closed
isaisabel opened this issue Nov 26, 2018 · 7 comments
Closed

Dark Theme #71

isaisabel opened this issue Nov 26, 2018 · 7 comments
Assignees
Labels
enhancement New feature or request Points: 5 5 agile story points seeking feedback Seeking feedback from the community on this issue timescale/imminent Ready to be assigned to developers

Comments

@isaisabel
Copy link
Contributor

An accessibility nice-to-have would be multiple visual themes for the Navigator. People working in low-light environments may find the white background of our current theme blinding. Adding an alternate color scheme with a dark background and light text (a "dark theme") would improve usability for demos or workspaces with lower light levels.

Optimally the user would be able to change the theme live in the application (perhaps using a dropdown next to the help button in the top right). The application should remember the previous theme selection using cookies.

@isaisabel isaisabel added enhancement New feature or request seeking feedback Seeking feedback from the community on this issue labels Nov 26, 2018
@isaisabel isaisabel added the timescale/long-term Issue to think about later label Nov 21, 2019
@isaisabel isaisabel added timescale/imminent Ready to be assigned to developers and removed timescale/long-term Issue to think about later labels Jun 16, 2021
@isaisabel isaisabel added this to the Version 4.5 milestone Jun 16, 2021
@isaisabel isaisabel added the Points: 5 5 agile story points label Jun 24, 2021
@jinxka
Copy link

jinxka commented Sep 6, 2021

A better solution is to use the direct css selector prefers-color-scheme instead of cookies.

Thank you.

@isaisabel
Copy link
Contributor Author

@jinxka thanks for pointing that out, I didn't know that existed! I think there are cases where a user may want to override that setting, but it'd definitely be good to allow the user's OS selected theme to be inherited. Like how Slack allows for the user to sync theme with OS settings or override for that specific application:

image

@isaisabel
Copy link
Contributor Author

Dark theme is now out with the v4.5.1 release.

image

@isaisabel isaisabel removed this from the Version 4.6.0 milestone Nov 12, 2021
@agg-mb
Copy link

agg-mb commented May 25, 2023

@isaisabel Thanks for the implementation. I might have overseen it, but I am afraid I couldn't find the option to turn on the dark theme. In the help menu at the top right there's no documentation of the dark theme, could it please be added there?

In short: How do I turn on the dark theme?

Thanks!

@isaisabel
Copy link
Contributor Author

Hi @agg-mb,

The dark theme control is available on the new tab interface here:

Screenshot 2023-05-25 at 1 13 45 PM

You seem to be correct that the USAGE document does not mention the dark theme. I'm not actually maintaining ATT&CK Navigator anymore so I'll leave that potential change to the current maintainers (@clemiller from the look of it).

@agg-mb
Copy link

agg-mb commented May 26, 2023

Thanks so much @isaisabel !

One more question @clemiller :
Is it possible yet to render the SVG in the dark theme? it comes out as light themed for me:
image

@jondricek
Copy link
Contributor

@agg-mb I created a new issue to track the request for SVG output having a dark theme. Short answer is that it is not possible right now however. Thank you for the request though!

#556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Points: 5 5 agile story points seeking feedback Seeking feedback from the community on this issue timescale/imminent Ready to be assigned to developers
Projects
None yet
Development

No branches or pull requests

5 participants