SVG toolbar dark mode colors #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemiller
requested changes
Apr 4, 2023
There was a problem hiding this comment.
This is a much needed improvement, thanks for opening up a PR! There are a couple additional dark mode issues in the SVG interface under the "legend" options:
And the drop down arrows in the mat-select fields:
Would you mind adjusting these as well to include as part of this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Navigator in dark mode, under "render layer to SVG", "image size", the unit suffix for "header height" is black. Additionally, the placeholder text for all the dropdown menus under "render layer to SVG" are black (font, sub-techniques, etc.). This changes their colors to white to match the styling of the rest of the toolbar.