-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development fix #861
Development fix #861
Conversation
…d into fix/broken-gems
…recated in conjunction with other gems. resolved a lint error relating to validating teams when they're required on a user
…d into fix/broken-gems
…d into fix/broken-gems
…d into fix/broken-gems
…d into fix/broken-gems
…d into rails-admin-3-fix
…to debug mode as before
This pull request has conflict. Could you fix it @Domur? |
I'd really suggest against upgrading |
Hey Robert, thanks for the comment. I think what this was addressing was that after upgrading rails_admin to 3.0.0 (to make use of Bootstrap 5) the Sprockets asset pipeline was broken for development. Files that required jQuery would sometimes be required before jQuery had fully loaded. I found that upgrading Sass and Sprockets fixed the issue, and haven't seen any problems with it so far. Why should it be avoided? |
Perhaps I've just been very unlucky but I've had sass/sassc-rails#122 pop up a decent number of times across different projects with sassc and generally at the worst times possible when trying to actually deploy or causing intermittent test failures. If I'm remembering correctly it seems especially susceptible to trying to deploy the application in Dokku which I would normally use for deploying this app in production. Looking at the current instance of the app, the only error I'm actually seeing when running the main branch is |
Hmm, interesting. I'll take another look and make sure everything seems good still. Thanks for having taken the time to check in on this. |
…d into development-fix
…d into development-fix
…scoreboard into development-fix
Fixes the development environment by updating sprockets to fix the pipeline issue that was affecting assets being loaded in the correct order. Reenabled debug mode.