Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development fix #861

Merged
merged 23 commits into from
Jun 13, 2022
Merged

Development fix #861

merged 23 commits into from
Jun 13, 2022

Conversation

Domur
Copy link
Contributor

@Domur Domur commented Apr 27, 2022

Fixes the development environment by updating sprockets to fix the pipeline issue that was affecting assets being loaded in the correct order. Reenabled debug mode.

Domur added 16 commits February 17, 2022 16:13
…recated in conjunction with other gems. resolved a lint error relating to validating teams when they're required on a user
@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2022

This pull request has conflict. Could you fix it @Domur?

@rbclark
Copy link
Contributor

rbclark commented Jun 10, 2022

I'd really suggest against upgrading sass-rails, based on my experience sass-rails 6.0 is a real bear and should be completely avoided. With that said I'm not 100% sure what you were fixing here.

@Domur
Copy link
Contributor Author

Domur commented Jun 10, 2022

Hey Robert, thanks for the comment.

I think what this was addressing was that after upgrading rails_admin to 3.0.0 (to make use of Bootstrap 5) the Sprockets asset pipeline was broken for development. Files that required jQuery would sometimes be required before jQuery had fully loaded. I found that upgrading Sass and Sprockets fixed the issue, and haven't seen any problems with it so far. Why should it be avoided?

@rbclark
Copy link
Contributor

rbclark commented Jun 10, 2022

Perhaps I've just been very unlucky but I've had sass/sassc-rails#122 pop up a decent number of times across different projects with sassc and generally at the worst times possible when trying to actually deploy or causing intermittent test failures. If I'm remembering correctly it seems especially susceptible to trying to deploy the application in Dokku which I would normally use for deploying this app in production.

Looking at the current instance of the app, the only error I'm actually seeing when running the main branch is Uncaught TypeError: filterrificForm is null, which is being caused by filterific. I'm not sure why I pinned it to the non-jquery version previously, I think it has having another conflict at that point. When testing locally I removed gem 'sassc-rails' from the bottom of the gemfile and everything seemed to still be functioning properly.

@Domur
Copy link
Contributor Author

Domur commented Jun 11, 2022

Hmm, interesting. I'll take another look and make sure everything seems good still. Thanks for having taken the time to check in on this.

@Domur Domur merged commit 5ca83e7 into master Jun 13, 2022
@mergify mergify bot deleted the development-fix branch June 13, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants