Auto event log generation when operation finishes #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uruwhy
force-pushed
the
VIRTS-1785-event-log-auto
branch
from
4bdd612
to
b3ce2ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #2088 +/- ##
==========================================
+ Coverage 65.60% 65.68% +0.07%
==========================================
Files 65 65
Lines 4876 4890 +14
==========================================
+ Hits 3199 3212 +13
- Misses 1677 1678 +1
Continue to review full report at Codecov.
|
uruwhy
force-pushed
the
VIRTS-1785-event-log-auto
branch
from
df52099
to
b3ce2ff
Compare
protoli
previously approved these changes
Mar 24, 2021
garunagiri
suggested changes
Mar 26, 2021
uruwhy
force-pushed
the
VIRTS-1785-event-log-auto
branch
from
b3ce2ff
to
ec13291
Compare
garunagiri
previously approved these changes
Mar 26, 2021
protoli
previously approved these changes
Mar 26, 2021
uruwhy
force-pushed
the
VIRTS-1785-event-log-auto
branch
from
7a58ee3
to
93f897f
Compare
protoli
previously approved these changes
Mar 30, 2021
wbooth
suggested changes
Mar 31, 2021
|
when comments are resolved, please send to @bworrell for review |
Adding test for auto event log generation and changing method name Test style fix Clearer variable name
uruwhy
force-pushed
the
VIRTS-1785-event-log-auto
branch
from
93f897f
to
e968821
Compare
bworrell
reviewed
Apr 1, 2021
bworrell
approved these changes
Apr 2, 2021
wbooth
approved these changes
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Event logs are automatically generated and written to disk when an operation finishes. The event log directory is placed in the
event_logssubdirectory of thereports_dirdirectory as specified in the CALDERA configuration (e.g./tmp/event_logs). The event log file is of the formatoperation_$ID.json, where$IDis the operation's ID number.Type of change
How Has This Been Tested?
Added a test to verify the operation method to generate the event log file.
Checklist: