Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve flake8 errors #2376

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Resolve flake8 errors #2376

merged 3 commits into from
Nov 29, 2021

Conversation

argaudreau
Copy link
Contributor

Description

Flake8 tests were failing for all new builds, so this resolves them so new PRs can be merged.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Flake8 tests pass locally.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@argaudreau argaudreau requested a review from a team as a code owner November 29, 2021 19:33
@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #2376 (7196156) into master (9b43a7f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2376   +/-   ##
=======================================
  Coverage   72.59%   72.59%           
=======================================
  Files         110      110           
  Lines        7947     7947           
=======================================
  Hits         5769     5769           
  Misses       2178     2178           
Impacted Files Coverage Δ
app/api/packs/advanced.py 75.00% <ø> (ø)
app/api/packs/campaign.py 30.61% <ø> (ø)
app/api/rest_api.py 59.29% <ø> (ø)
app/api/v2/handlers/base_object_api.py 86.00% <ø> (ø)
app/api/v2/handlers/operation_api.py 98.70% <ø> (ø)
app/api/v2/managers/ability_api_manager.py 90.00% <ø> (ø)
app/api/v2/managers/base_api_manager.py 96.46% <ø> (ø)
app/api/v2/managers/operation_api_manager.py 89.00% <ø> (ø)
app/contacts/contact_gist.py 50.76% <ø> (ø)
app/contacts/contact_html.py 59.09% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2dc4d...7196156. Read the comment docs.

@wbooth wbooth merged commit 1587d2b into master Nov 29, 2021
@wbooth wbooth deleted the fix_flake8_test branch November 29, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants