Fix asyncio.start_server call (unexpected keyword argument 'loop') #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loop parameter was not necessary and was removed in Python 3.10.
|
Kudos, SonarCloud Quality Gate passed! |
elegantmoose
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The loop parameter was not necessary and was removed in Python 3.10. This was causing an error preventing the server from starting up at all in Python 3.10.
Fixes #2611.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Started up the server under both Python 3.10.5 and Python 3.7.5 and confirmed that the server started up without any related errors.
Checklist: