Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Save & Add error on ability modal #2637

Merged
merged 5 commits into from
Aug 13, 2022
Merged

Conversation

argaudreau
Copy link
Contributor

Description

Fixes a bug where when viewing an ability on the adversaries page, clicking the "Save & Add" button would lock up the page, requiring a page reload.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

In Firefox, Chrome, and Safari, I am able to click Save & Add and the page no longer freezes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ZacharyLPalmer
Copy link
Contributor

Looks good, confirmed works on Chrome and Firefox.

@ZacharyLPalmer ZacharyLPalmer self-requested a review August 11, 2022 18:14
@elegantmoose elegantmoose merged commit 55c8cda into master Aug 13, 2022
@elegantmoose elegantmoose deleted the adversary_save_fix branch August 13, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants