Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match potential link on platform and name #2843

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

d3vco
Copy link
Contributor

@d3vco d3vco commented Nov 7, 2023

Description

Fixes a bug that could cause the wrong platform's executor to be selected when adding a potential link to an operation.

Resolves #2842

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested manually by following the steps described in issue #2842

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
    • Not required
  • I have added tests that prove my fix is effective or that my feature works
    • No test system in place for template javascript code

@d3vco d3vco closed this Nov 7, 2023
@d3vco
Copy link
Contributor Author

d3vco commented Nov 7, 2023

First commit had inadvertently changed style. Styling has been restored.

Resolves #2842

@d3vco d3vco reopened this Nov 7, 2023
Copy link

github-actions bot commented Dec 8, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot closed this Dec 21, 2023
@elegantmoose elegantmoose reopened this Dec 27, 2023
@github-actions github-actions bot closed this Jan 4, 2024
@clenk clenk reopened this Jan 19, 2024
Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@clenk clenk merged commit 5a090ee into mitre:master Jan 19, 2024
3 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Potential Link Executor Selection
3 participants