Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Non-packaged libraries to be under "common" #6538

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Conversation

em-c-rod
Copy link
Contributor

@em-c-rod em-c-rod commented Jan 17, 2025

This is cherry-picked work taken from the FIPs PR to nest the interfaces library under the name "common". The idea is that additional custom packages can be put in this "common" library instead of adding them separating as their own thing.

I separated it to make the FIPs PR easier to debug and review.

Amndeep7 and others added 6 commits January 17, 2025 16:39
…aces to libs/common so that it could include more common functionality than just the interfaces

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Emily Rodriguez <erodriguez92@gatech.edu>
@em-c-rod em-c-rod marked this pull request as ready for review January 20, 2025 16:07
Copy link
Contributor

@Amndeep7 Amndeep7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to see if I could get the nested structure to work properly but it was getting to be too large since it started getting into the tsconfig stuff all over the place. This builds and runs so it's fine.

@Amndeep7 Amndeep7 enabled auto-merge (squash) January 22, 2025 00:01
@em-c-rod em-c-rod self-assigned this Jan 22, 2025
@Amndeep7 Amndeep7 merged commit 2fd3906 into master Jan 23, 2025
18 checks passed
@mergify mergify bot deleted the library-rename branch January 23, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants