Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Group field in Operation Details #59

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Fix the Group field in Operation Details #59

merged 2 commits into from
Jul 1, 2024

Conversation

guillaume-duong-bib
Copy link
Contributor

@guillaume-duong-bib guillaume-duong-bib commented Jun 18, 2024

Fixes mitre/caldera#3005: the Operation Details popup does not display the correct value when an operation has a specific agent group selected.

This field is currently filled this way:
td {{operationStore.operations[operationStore.selectedOperationID].autonomous ? "all" : "red"}}
But I don't see how the autonomous aspect of an operation correlates in any way to its target agent group, thus the suggested change.

Here's an operation created with the group "yellow" selected, before:
image

and after:
image

@elegantmoose elegantmoose self-requested a review June 21, 2024 20:46
@elegantmoose
Copy link
Collaborator

On queue

@guillaume-duong-bib
Copy link
Contributor Author

@maxime-escourbiac-bib

Copy link
Collaborator

@elegantmoose elegantmoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you @guillaume-duong-bib .

@elegantmoose elegantmoose merged commit 447267c into mitre:master Jul 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent Group not displayed properly in Operation Details
2 participants