Move @oclif/test to devDependencies #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@oclif/test is used for testing, not at runtime, so it shouldn't be a dependency.
|
Kudos, SonarCloud Quality Gate passed!
|
candrews
added a commit
to candrews/jumpstart
that referenced
this pull request
Oct 18, 2023
Sinon erroneously currently requires git to be installed: sinonjs/sinon#2557 However, sinon is a testing tool which should even be used anyways: mitre/saf#1919
candrews
added a commit
to candrews/jumpstart
that referenced
this pull request
Oct 18, 2023
Sinon erroneously currently requires git to be installed: sinonjs/sinon#2557 However, sinon is a testing tool which should even be used anyways: mitre/saf#1919
Amndeep7
approved these changes
Oct 18, 2023
Amndeep7
added
the
ready-to-merge
Devhunter416
pushed a commit
to Devhunter416/jumpstart
that referenced
this pull request
Mar 6, 2024
Sinon erroneously currently requires git to be installed: sinonjs/sinon#2557 However, sinon is a testing tool which should even be used anyways: mitre/saf#1919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oclif/testis used for testing, not at runtime, so it shouldn't be a dependency.@oclif/testpulls insinon, in which the current version16.1.1requiresgitto be installed which is a problem for systems that don't/can't havegitinstalled: sinonjs/sinon#2557