Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VIRTS-4152] Include exit code in agent's link results #427

Merged
merged 7 commits into from
Feb 14, 2023

Conversation

michael-the-jones
Copy link
Contributor

@michael-the-jones michael-the-jones commented Dec 22, 2022

Description

Dependent on mitre/caldera PR (mitre/caldera#2713).

Include exit code in agent's link results. For the Shellcode, Shells, Native, and Donut executors, exit code will now be returned from the agent. While Shells and Donut exit codes come from the OS/shell itself, Shellcode and Native are hard-coded descriptors used for consistency across executors.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested shellcode, shells, and native code execution paths manually and with assistance of unit tests. Changes are relatively not invasive, and strong code review could provide some level of assurance.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [Future mitre/fieldmanual PR] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@elegantmoose elegantmoose merged commit 7c326bd into master Feb 14, 2023
@clenk clenk deleted the VIRTS-4152 branch June 23, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants