Up to deep linking #552
Merged
Up to deep linking #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Proof of Concept for Deeplinking Controls * Fix URL after initial load, remove byebug * lint, comment and optimize code Signed-off-by: Vanessa Fotso <vfotso@mitre.org> * Updated Link location and style * Fixed linting issue * Fixed search control that broke by deep linking * Proof of Concept for Deeplinking Controls * Fix URL after initial load, remove byebug * lint, comment and optimize code Signed-off-by: Vanessa Fotso <vfotso@mitre.org> * Updated Link location and style * Fixed linting issue --------- Signed-off-by: Vanessa Fotso <vfotso@mitre.org> Co-authored-by: freddyfeelgood <darrickw@vmware.com>
customized parser to not inteprete character/html entity Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Bumps [rack](https://github.com/rack/rack) from 2.2.6.3 to 2.2.6.4. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md) - [Commits](rack/rack@v2.2.6.3...v2.2.6.4) --- updated-dependencies: - dependency-name: rack dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [rack](https://github.com/rack/rack) from 2.2.6.3 to 2.2.6.4. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rack/rack/commit/27addc7f1ae290b6b84c1c351e5b6d75a05bb40b"><code>27addc7</code></a> bump version</li> <li><a href="https://github.com/rack/rack/commit/ee7919ea04303717858be1c3f16b406adc6d8cff"><code>ee7919e</code></a> Avoid ReDoS problem</li> <li>See full diff in <a href="https://github.com/rack/rack/compare/v2.2.6.3...v2.2.6.4">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/mitre/vulcan/network/alerts). </details>
|
Couple of potential issues observed. Sometimes a component when opening it would not load the controls. We would see the top Vulcan navigation bar but nothing below it...just a white screen. Refreshing sometimes resolved this. Secondly we were having issues with the Diff Viewer and receiving a "The requested component and control combination could not be found." error. This error would pop up after selecting the first component for comparison. The 2nd list would never populate and just be empty. |
rlakey
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the backup brach, since the master was rolled back to before the deep linking pr