Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VULCAN- 565: Add latest release version tag to Navbar component #567

Merged
merged 2 commits into from
May 2, 2023

Conversation

vanessuniq
Copy link
Contributor

This pull request adds the latest release version tag to the Navbar component. The tag is fetched from the GitHub API and displayed next to the "VULCAN" text. It improves the user experience by showing the current release version prominently.

Changes Made:

  • Updated the template to include the latest release tag
  • Added a method & mounted property to handle asynchronous API call
  • Applied CSS styling to the latest release value for a smaller font size

Fixes #565

@vanessuniq vanessuniq added javascript Pull requests that update Javascript code feature request labels Apr 26, 2023
@vanessuniq vanessuniq requested a review from rlakey April 26, 2023 22:35
@vanessuniq vanessuniq linked an issue Apr 26, 2023 that may be closed by this pull request
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-567 April 26, 2023 22:35 Inactive
@vanessuniq vanessuniq enabled auto-merge (squash) April 26, 2023 22:36
@rlakey
Copy link
Contributor

rlakey commented Apr 27, 2023

I like how it looks but a couple things. I don't want to display the latest but the version that Vulcan is currently running.

Also this requires internet access and some deployments of Vulcan may be in an environment without that.

@aaronlippold Do we want to enable any features that require internet access?

@vanessuniq
Copy link
Contributor Author

I like how it looks but a couple things. I don't want to display the latest but the version that Vulcan is currently running.

Also this requires internet access and some deployments of Vulcan may be in an environment without that.

@aaronlippold Do we want to enable any features that require internet access?

Ok, this can be accomplished by setting the config. But it will be a manual task to update the version

@vanessuniq
Copy link
Contributor Author

vanessuniq commented May 1, 2023

Update: displaying the version that Vulcan is currently running will be read from packge.json. This requires consistently update the app version in package.json with every release. if we want to notify the user of a newer version available, it will require internet access, fetching the latest version from github.

Screenshot 2023-05-02 at 11 57 59 AM

@vanessuniq vanessuniq requested review from rlakey and removed request for rlakey May 2, 2023 16:23
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
…new version available

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq merged commit c50ecb6 into master May 2, 2023
@vanessuniq vanessuniq deleted the 565-add-version-info-to-ui branch May 2, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request javascript Pull requests that update Javascript code
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Add version info to UI
2 participants