Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VULCAN-559: Support for Multiple CCIs #569

Merged
merged 2 commits into from
May 5, 2023
Merged

Conversation

vanessuniq
Copy link
Contributor

  • Reading ccis from the imported spreadsheet
  • Refactored getting nist_control_family to accomodate for instances of multi ccis
  • Refactored inspec code to accomodate for instances of multi ccis

Screenshot 2023-05-03 at 12 09 31 PM

Screenshot 2023-05-03 at 12 10 04 PM

Am I missing a workflow that uses rule.ident?

Fix #559

@vanessuniq vanessuniq added the bug Something isn't working label May 3, 2023
@vanessuniq vanessuniq requested a review from rlakey May 3, 2023 16:47
@vanessuniq vanessuniq linked an issue May 3, 2023 that may be closed by this pull request
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-569 May 3, 2023 16:47 Inactive
Refactored getting nist_control_family to accomodate for instances of multi ccis

Refactored inspec code to accomodate for instances of multi ccis

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-569 May 3, 2023 17:00 Inactive
Rspec test for rules with multiple CCI

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
@vanessuniq vanessuniq temporarily deployed to vulcan-pr-569 May 3, 2023 19:06 Inactive
Copy link
Contributor

@freddyfeelgood freddyfeelgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after the sort addition.

@vanessuniq vanessuniq merged commit 24831cb into master May 5, 2023
@vanessuniq vanessuniq deleted the 559-support-multiple-ccis branch May 5, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Support multiple cci's
2 participants