Fix Related Rules Grouping #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
There was a problem hiding this comment.
@vanessuniq I was getting errors when pressing "Enter" on the search block for the toLowerCase() conversion when the text was null. I added a "convertLower" function that returns empty string if the text is null. If you want to change it (to return null, or just return 'text', etc.), please do.
Everything else looks great! I tested with admin rights and with just plain user rights and everything looks good.
Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
vanessuniq
commented
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Some Vulcan components are added to multiple projects as overlaid causing some related rules results to appear as duplicate when grouping by rules by component name only.
Changes