Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Known Isuses Blocked on Externally #127

Open
mitsuhiko opened this issue Jun 30, 2020 · 1 comment
Open

Known Isuses Blocked on Externally #127

mitsuhiko opened this issue Jun 30, 2020 · 1 comment

Comments

@mitsuhiko
Copy link
Owner

This is a meta issue about problems insta is running into, that insta cannot resolve itself without external help:
@mitsuhiko mitsuhiko pinned this issue Jun 30, 2020
@max-sixty
Copy link
Collaborator

On the second, I had a branch at one point that added cargo as an optional dependency to avoid shelling out. But it caused massive bloat, so I abandoned it pretty quickly.

mitsuhiko added a commit that referenced this issue Jan 25, 2022
@mitsuhiko
Detect snapshot names from function names
b2e32ae 
We used to detect the snapshot names form the current thread.  This has
been very unrealiable in a lot of cases.  This changes the behavior so
that the function name is used instead by using `std::any::type_name`.

This does change behavior slightly but most users should not notice this
change except if they relied on helper functions.  In that case using a
macro is a better solution most likely.

Refs #127 and #105
@mitsuhiko mitsuhiko mentioned this issue Jan 25, 2022
Merged
mitsuhiko added a commit that referenced this issue Jan 25, 2022
@mitsuhiko
Detect snapshot names from function names (#213)
758eb6a 
We used to detect the snapshot names form the current thread.  This has
been very unrealiable in a lot of cases.  This changes the behavior so
that the function name is used instead by using `std::any::type_name`.

This does change behavior slightly but most users should not notice this
change except if they relied on helper functions.  In that case using a
macro is a better solution most likely.

Refs #127

Fixes #105
@mitsuhiko mitsuhiko unpinned this issue Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitsuhiko @max-sixty