Fix source path in snapshots for non-child workspaces #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a helper function to compute relative paths between arbitrary directories. This is used to ensure the `source` field in snapshots is relative to the workspace root, even when the project is not a direct child of the workspace directory. This resolves issue mitsuhiko#777 where the source path would become absolute in such setups. Includes tests for the fix. Co-authored-by: Claude <no-reply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper function to compute relative paths between arbitrary directories. This is used to ensure the
sourcefield in snapshots is relative to the workspace root, even when the project is not a direct child of the workspace directory. This resolves issue #777 where the source path would become absolute in such setups. Includes tests for the fix.Co-authored-by: Claude no-reply@anthropic.com