Fix backward compatibility for --test-runner-fallback true syntax #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small fix to PR mitsuhiko#811 which introduced `--test-runner-fallback` and `--no-test-runner-fallback` flags. ## Issue The previous PR added `require_equals = true` to the clap argument configuration, which broke backward compatibility with the space syntax: - ❌ `--test-runner-fallback true` (broke in mitsuhiko#811) - ✅ `--test-runner-fallback=true` (still worked) The old implementation accepted both syntaxes, so this was a regression. ## Fix Removed `require_equals = true` from the argument configuration to restore backward compatibility. This allows all syntaxes to work: **New ergonomic syntax:** - `--test-runner-fallback` (no value) - `--no-test-runner-fallback` **Backward compatible syntax:** - `--test-runner-fallback true` (with space) ✅ now fixed - `--test-runner-fallback=true` (with equals) - `--test-runner-fallback false` - `--test-runner-fallback=false` ## Testing - Added new test `test_runner_fallback_space_true` to cover the space syntax - All 7 test_runner_fallback tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix to PR #811 which introduced
--test-runner-fallbackand--no-test-runner-fallbackflags.Issue
The previous PR added
require_equals = trueto the clap argument configuration, which broke backward compatibility with the space syntax:--test-runner-fallback true(broke in Add ergonomic --test-runner-fallback/--no-test-runner-fallback flags #811)--test-runner-fallback=true(still worked)The old implementation accepted both syntaxes, so this was a regression.
Fix
Removed
require_equals = truefrom the argument configuration to restore backward compatibility. This allows all syntaxes to work:New ergonomic syntax:
--test-runner-fallback(no value)--no-test-runner-fallbackBackward compatible syntax:
--test-runner-fallback true(with space) ✅ now fixed--test-runner-fallback=true(with equals)--test-runner-fallback false--test-runner-fallback=falseTesting
test_runner_fallback_space_trueto cover the space syntaxChanges
require_equals = truefromcargo-insta/src/cli.rscargo-insta/tests/functional/test_runner_fallback.rs🤖 Generated with Claude Code