Add --dnd alias for --disable-nextest-doctest flag #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a shorter `--dnd` alias for the `--disable-nextest-doctest` flag to make it easier to silence the deprecation warning during the transition period when nextest won't run doctests by default. Changes: - Add `alias = "dnd"` to the disable_nextest_doctest CLI argument - Update warning message to mention the --dnd alias - Add test to verify the --dnd alias works correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Nov 20, 2025
## Summary Prepare for the 1.44.1 patch release: - Bump version to 1.44.1 in `insta/Cargo.toml` and `cargo-insta/Cargo.toml` - Update CHANGELOG.md with changes since 1.44.0 ## Changes in 1.44.1 - Add `--dnd` alias for `--disable-nextest-doctest` flag mitsuhiko#822 - Update cargo-dist to 0.30.2 and fix Windows runner mitsuhiko#821 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Merged
max-sixty
added a commit
that referenced
this pull request
Nov 20, 2025
## Summary Prepare for the 1.44.1 patch release with two changes since 1.44.0. ## Changes - Add `--dnd` alias for `--disable-nextest-doctest` flag to make it easier to silence the deprecation warning (#822) - Update cargo-dist to 0.30.2 and fix Windows runner to use windows-2022 (#821) ## Version Updates - Bump version to 1.44.1 in `insta/Cargo.toml` and `cargo-insta/Cargo.toml` - Update CHANGELOG.md with release notes - Update Cargo.lock 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Nov 27, 2025
## Summary Adds a shorter `--dnd` alias for the `--disable-nextest-doctest` flag to make it easier to silence the deprecation warning during the transition period. This addresses the request from @ilyagr in mitsuhiko#803: > It seems like people will pass this flag often to avoid the deprecation warning. Perhaps give it a short version, e.g. `-D`? After discussion, we agreed on `--dnd` as the alias. ## Changes - Add `alias = "dnd"` to the `disable_nextest_doctest` CLI argument - Update deprecation warning message to mention the `--dnd` alias: `Pass '--disable-nextest-doctest' (or '--dnd') to update to this behavior now and silence this warning.` - Add test `test_nextest_doctest_dnd_alias_no_warning()` to verify the alias works correctly ## Test plan - [x] All existing tests pass (5/5 in nextest_doctest module) - [x] New test verifies `--dnd` alias works correctly - [x] Lints pass (cargo fmt, cargo clippy) - [x] Manual verification: `cargo insta test --test-runner nextest --dnd` works as expected ## Usage Both forms work identically: ```bash cargo insta test --test-runner nextest --disable-nextest-doctest cargo insta test --test-runner nextest --dnd ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Nov 27, 2025
## Summary Prepare for the 1.44.1 patch release with two changes since 1.44.0. ## Changes - Add `--dnd` alias for `--disable-nextest-doctest` flag to make it easier to silence the deprecation warning (mitsuhiko#822) - Update cargo-dist to 0.30.2 and fix Windows runner to use windows-2022 (mitsuhiko#821) ## Version Updates - Bump version to 1.44.1 in `insta/Cargo.toml` and `cargo-insta/Cargo.toml` - Update CHANGELOG.md with release notes - Update Cargo.lock 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a shorter
--dndalias for the--disable-nextest-doctestflag to make it easier to silence the deprecation warning during the transition period.This addresses the request from @ilyagr in #803:
After discussion, we agreed on
--dndas the alias.Changes
alias = "dnd"to thedisable_nextest_doctestCLI argument--dndalias:Pass '--disable-nextest-doctest' (or '--dnd') to update to this behavior now and silence this warning.test_nextest_doctest_dnd_alias_no_warning()to verify the alias works correctlyTest plan
--dndalias works correctlycargo insta test --test-runner nextest --dndworks as expectedUsage
Both forms work identically:
🤖 Generated with Claude Code