Skip nextest_doctest tests when cargo-nextest is not installed #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mitsuhiko#825 - Tests were failing on systems without cargo-nextest because they directly invoke `cargo nextest run` without checking for its availability first. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Nov 27, 2025
## Changes - Fix backward compatibility for legacy inline snapshot format. Snapshots using single-line content in multiline raw strings now correctly match again. (mitsuhiko#830) - Handle merge conflicts in snapshot files gracefully. When a snapshot file contains git merge conflict markers, insta now detects them and treats the snapshot as missing, allowing tests to continue and create a new pending snapshot for review. (mitsuhiko#829) - Skip nextest_doctest tests when cargo-nextest is not installed. (mitsuhiko#826) - Fix functional tests failing under nextest due to inherited `NEXTEST_RUN_ID` environment variable. (mitsuhiko#824) ## Version Updates - Bump version to 1.44.2 in `insta/Cargo.toml` and `cargo-insta/Cargo.toml` - Update CHANGELOG.md with release notes - Update Cargo.lock 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Nov 27, 2025
## Changes - Fix backward compatibility for legacy inline snapshot format. Snapshots using single-line content in multiline raw strings now correctly match again. (mitsuhiko#830) - Handle merge conflicts in snapshot files gracefully. When a snapshot file contains git merge conflict markers, insta now detects them and treats the snapshot as missing, allowing tests to continue and create a new pending snapshot for review. (mitsuhiko#829) - Skip nextest_doctest tests when cargo-nextest is not installed. (mitsuhiko#826) - Fix functional tests failing under nextest due to inherited `NEXTEST_RUN_ID` environment variable. (mitsuhiko#824) ## Version Updates - Bump version to 1.44.2 in `insta/Cargo.toml` and `cargo-insta/Cargo.toml` - Update CHANGELOG.md with release notes - Update Cargo.lock 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
max-sixty
added a commit
that referenced
this pull request
Nov 27, 2025
## Summary Prepare for the 1.44.2 patch release with four changes since 1.44.1. ## Changes - Fix backward compatibility for legacy inline snapshot format. Snapshots using single-line content in multiline raw strings now correctly match again. (#830) - Handle merge conflicts in snapshot files gracefully. When a snapshot file contains git merge conflict markers, insta now detects them and treats the snapshot as missing, allowing tests to continue and create a new pending snapshot for review. (#829) - Skip nextest_doctest tests when cargo-nextest is not installed. (#826) - Fix functional tests failing under nextest due to inherited `NEXTEST_RUN_ID` environment variable. (#824) ## Version Updates - Bump version to 1.44.2 in `insta/Cargo.toml` and `cargo-insta/Cargo.toml` - Update CHANGELOG.md with release notes - Update Cargo.lock ## Test plan - [x] All tests pass - [x] Pre-commit lints pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Nov 27, 2025
…hiko#826) ## Summary - Add `nextest_available()` helper function to check if cargo-nextest is installed - Skip the 4 nextest_doctest tests with an informative message when nextest is unavailable Fixes mitsuhiko#825 ## Test plan - [x] Tests pass with nextest installed - [x] Clippy passes - [ ] Verify tests skip gracefully without nextest (reported in issue) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Nov 27, 2025
## Summary Prepare for the 1.44.2 patch release with four changes since 1.44.1. ## Changes - Fix backward compatibility for legacy inline snapshot format. Snapshots using single-line content in multiline raw strings now correctly match again. (mitsuhiko#830) - Handle merge conflicts in snapshot files gracefully. When a snapshot file contains git merge conflict markers, insta now detects them and treats the snapshot as missing, allowing tests to continue and create a new pending snapshot for review. (mitsuhiko#829) - Skip nextest_doctest tests when cargo-nextest is not installed. (mitsuhiko#826) - Fix functional tests failing under nextest due to inherited `NEXTEST_RUN_ID` environment variable. (mitsuhiko#824) ## Version Updates - Bump version to 1.44.2 in `insta/Cargo.toml` and `cargo-insta/Cargo.toml` - Update CHANGELOG.md with release notes - Update Cargo.lock ## Test plan - [x] All tests pass - [x] Pre-commit lints pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nextest_available()helper function to check if cargo-nextest is installedFixes #825
Test plan
🤖 Generated with Claude Code