-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mandatory serde dependency #539
base: main
Are you sure you want to change the base?
Conversation
Another option entirely is to no longer use |
FYI just in case you weren't aware and it affects the decision when/how to do this: the warning added in #541 only shows up when using minijinja as a path dependency. Cargo uses |
You can use https://docs.rs/build-alert for warnings that show up inside ordinary crates.io dependencies. |
This PR makes
serde
optional in MiniJinja. The way to use this is to disable default features which also turns offserde
. Unfortunately this is not semver compatible as it means that anyone currently using MiniJinja without serde will experience breakage.Additionally it changes the behavior of
context!
to take things by value. The benefit of this is that the macro can now support bothInto<Value>
andSerialize
as conversions.This will have to go into a new major version.
Fixes #528