feat(minijnija-cli): add support for using env for options #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onedr0p
force-pushed
the
minijinja-cli-env
branch
from
80da2a3 to
c95723c
Compare
onedr0p
force-pushed
the
minijinja-cli-env
branch
from
0529a8d to
a3f281f
Compare
onedr0p
changed the title
|
@mitsuhiko would you appreciate tests added for this too? Edit: test added |
onedr0p
force-pushed
the
minijinja-cli-env
branch
from
0ecfe15 to
8563c88
Compare
Signed-off-by: Devin Buhl <devin@buhl.casa> fix: keep super on func Signed-off-by: Devin Buhl <devin@buhl.casa> fix: forgot to update after testing Signed-off-by: Devin Buhl <devin@buhl.casa> fix: add back syntax descriptions Signed-off-by: Devin Buhl <devin@buhl.casa> fix: add a couple more env Signed-off-by: Devin Buhl <devin@buhl.casa> fix: enable env in cargo Signed-off-by: Devin Buhl <devin@buhl.casa>
onedr0p
force-pushed
the
minijinja-cli-env
branch
from
8414188 to
def97e8
Compare
Signed-off-by: Devin Buhl <devin@buhl.casa>
|
Fixes #600 |
|
I will try to base some work on this pull request. Since some flags can be set multiple times I will need to spend some time figuring out how to best configure this with envvars. It might be that it would be a better choice to just allow env-vars for some and provide an explicit config file instead. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏼
Simple change here to allow for using env to set options for minijinja-cli.
First time contributing Rust code, please be kind 😉
Related: #597