Fixed incorrect lexer position reports #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the logic in the lexer and parser so that on lexing errors the right information. The way this is correctly implemented is by making the lexer aware of the filename so that it can already report errors correctly. The error attachment logic in the parser is also slightly changed now.
It's a bit unfortunate that this breaks the unstable machinery API but I'm not sure if there is a particularly nice way to avoid that. At least this makes it slightly less weird. Now at least the lexer and parser are at least in the position of reporting the correct error locations on their own.
Fixes #445