Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added |truncate filter #644

Closed
wants to merge 3 commits into from
Closed

Added |truncate filter #644

wants to merge 3 commits into from

Conversation

yacir
Copy link
Contributor

@yacir yacir commented Nov 15, 2024

This adds the missing |truncate filter.

@mitsuhiko
Copy link
Owner

I'm in favor of adding it, but I would prefer that filter to land in minijinja-contrib given the rather complex implementation and that it's probably not used very frequently.

@yacir
Copy link
Contributor Author

yacir commented Nov 18, 2024

I understand your reasoning. Since this filter is native to Jinja2, it makes sense to consider adding it to the builtins. However, given the potential infrequent use, it might be more practical to include it in minijinja-contrib. I'll update the merge request.
Perhaps this could be revisited in v3.

@yacir
Copy link
Contributor Author

yacir commented Nov 18, 2024

replaced by #647

@yacir yacir closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants