[EuiNavDrawer] Fix scrolling in mobile view (elastic#3174)

miukimiu · Mar 30, 2020 · a07e19b · a07e19b
1 parent 862b94e
commit a07e19b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -39,6 +39,10 @@
 - Fixed `EuiSearchBar` related types ([#3147](https://github.com/elastic/eui/pull/3147))
 - Added `prepend` and `append` ability to `EuiSuperSelect` ([#3167](https://github.com/elastic/eui/pull/3167))
 
+**Bug Fixes**
+
+- Fixed `EuiNavDrawer` scrolling issue on mobile ([#3174](https://github.com/elastic/eui/pull/3174))
+
 ## [`22.0.0`](https://github.com/elastic/eui/tree/v22.0.0)
 
 - Replaced various `lodash` functions with native functions ([#3053](https://github.com/elastic/eui/pull/3053))

diff --git a/src/components/nav_drawer/__snapshots__/nav_drawer.test.js.snap b/src/components/nav_drawer/__snapshots__/nav_drawer.test.js.snap
@@ -5,7 +5,7 @@ exports[`EuiNavDrawer is rendered 1`] = `
  class="euiNavDrawer euiNavDrawer-isCollapsed euiNavDrawer-flyoutIsCollapsed"
 >
  <div
- class="euiFlexGroup euiFlexGroup--directionRow euiFlexGroup--responsive"
+ class="euiFlexGroup euiFlexGroup--directionRow"
  >
  <div
  class="euiFlexItem euiFlexItem--flexGrowZero"
@@ -266,7 +266,7 @@ exports[`EuiNavDrawer renders with falsy children 1`] = `
  class="euiNavDrawer euiNavDrawer-isCollapsed euiNavDrawer-flyoutIsCollapsed"
 >
  <div
- class="euiFlexGroup euiFlexGroup--directionRow euiFlexGroup--responsive"
+ class="euiFlexGroup euiFlexGroup--directionRow"
  >
  <div
  class="euiFlexItem euiFlexItem--flexGrowZero"
@@ -473,7 +473,7 @@ exports[`EuiNavDrawer renders with fragments 1`] = `
  class="euiNavDrawer euiNavDrawer-isCollapsed euiNavDrawer-flyoutIsCollapsed"
 >
  <div
- class="euiFlexGroup euiFlexGroup--directionRow euiFlexGroup--responsive"
+ class="euiFlexGroup euiFlexGroup--directionRow"
  >
  <div
  class="euiFlexItem euiFlexItem--flexGrowZero"

diff --git a/src/components/nav_drawer/nav_drawer.js b/src/components/nav_drawer/nav_drawer.js
@@ -347,7 +347,7 @@ export class EuiNavDrawer extends Component {
  onOutsideClick={() => this.closeBoth()}
  isDisabled={this.state.outsideClickDisabled}>
  <nav className={classes} {...rest}>
- <EuiFlexGroup gutterSize="none">
+ <EuiFlexGroup gutterSize="none" responsive={false}>
  <EuiFlexItem grow={false}>
  <div
  id={MENU_ELEMENT_ID}