Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some types #2

Merged
merged 1 commit into from
May 5, 2020
Merged

Update some types #2

merged 1 commit into from
May 5, 2020

Conversation

cchaos
Copy link

@cchaos cchaos commented May 5, 2020

Here is the work I went through. Mainly just the TS types

miukimiu
miukimiu approved these changes May 5, 2020
View reviewed changes
Copy link
Owner

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping me with this PR. LGTM! 🎉

@miukimiu miukimiu merged commit 7cc2855 into miukimiu:color-palette-picker May 5, 2020
@cchaos cchaos deleted the miukimiu-color-palette-picker branch September 11, 2020 15:39
miukimiu pushed a commit that referenced this pull request Jul 19, 2021
@rshen91
Merge pull request #2 from myasonik/pr/4916
f3ff52b 
Added a better example for the table caption and Goal chart cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miukimiu miukimiu miukimiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cchaos @miukimiu