Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More strict types #5

Merged
merged 2 commits into from
Jun 2, 2020
Merged

More strict types #5

merged 2 commits into from
Jun 2, 2020

Conversation

thompsongl
Copy link

This will makes some impossible states impossible (via type checking). Namely,

  • text options without title values
  • fixed types using ColorStop palette values

Also a minor refactor to reduce the number of calls to local utility functions.

@thompsongl thompsongl mentioned this pull request Jun 2, 2020
Merged
11 tasks
miukimiu
miukimiu approved these changes Jun 2, 2020
View reviewed changes
Copy link
Owner

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thompsongl! It looks good and professional!

src/components/color_picker/color_palette_picker/color_palette_picker.tsx Outdated Show resolved Hide resolved
@miukimiu miukimiu merged commit 62dc72c into miukimiu:color-palette-picker Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miukimiu miukimiu miukimiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thompsongl @miukimiu