Update fallback mirror list #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
miurahr
reviewed
Feb 6, 2022
aqt/settings.ini
Outdated
| https://mirrors.sjtug.sjtu.edu.cn/qt/ | ||
| https://mirrors.tuna.tsinghua.edu.cn/qt/ |
There was a problem hiding this comment.
This is problematic because it limit access connections unknown condition, maybe outside of china, and randomly failed, So it is listed in black list and it had been failed in past CI tests.
Could you remove blacklisted host?
There was a problem hiding this comment.
Or if it is healthy, please also update blacklist.
There was a problem hiding this comment.
Thanks for the pointer, should have caught that myself. I've updated the PR to avoid adding blacklisted entries.
While the mirror is currently reachable for me, it's rather slow and I don't know the history, so it might be better to keep it as-is.
Some of the currently listed mirrors are no longer part of the official mirror list by qt.io, some return 404, some don't fully mirror the tree. The list has been generated via the following one-liner: blacklist=$(sed -rne '/blacklist:/,/fallbacks:/p ' aqt/settings.ini); for mirror in $(curl -s https://download.qt.io/static/mirrorlist/ | grep -oP 'href="\K(http.*)(?=">HTTP</a>)' | sed -re 's|^http:|https:|; s|([^/])$|\1/|'); do grep -qF "$(sed -re 's|^https?://([^/]+).*$|\1|' <<<"${mirror}")" <<<"$blacklist" && continue; code=$(curl -I "${mirror}online/qtsdkrepository/windows_x86/desktop/qt6_623/qt.qt6.623.win64_msvc2019_64/6.2.3-0-202201260729qtbase-Windows-Windows_10_21H2-MSVC2019-Windows-Windows_10_21H2-X86_64.7z" --write-out '%{response_code}' --silent -o /dev/null); [[ $code == 200 ]] && echo " ${mirror}"; done
hoffie
force-pushed
the
remove-dead-mirrors
branch
from
062e391 to
10e5bdf
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the currently listed mirrors are no longer part of the official mirror list by qt.io, some return 404, some don't fully mirror the tree (especially
online/).The updated list has been generated via the following one-liner: