feat: ensure unpack_7zarchive closes the archive #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miurahr
reviewed
Apr 10, 2024
francoisfreitag
force-pushed
the
robust-unpack
branch
from
d19d7ae
to
e0e0abd
Compare
miurahr
added a commit
that referenced
this pull request
Jul 1, 2024
Fixed ----- * Follow shutil.register_unpack_format() convention of raising a ReadError when the library cannot handle a file (#583) * ensure unpack_7zarchive closes the archive (#584) * 64bit OS detection (#580) Added ----- * Add recursive sub-directories and files extraction (#585) Changed ------- * check targets argument type for read and extract method (#577) * Treat zero byte stream as a file (#551)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Which ticket is resolved?
None, it’s a pretty small implementation detail.
What does this PR change?
SevenZipFile.close()even when there was an exception duringextractall()inunpack_7zarchive().