Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3.13 support #619

Merged
merged 9 commits into from
Sep 27, 2024
Merged

feat: 3.13 support #619

merged 9 commits into from
Sep 27, 2024

Conversation

Ravencentric
Copy link
Contributor

@Ravencentric Ravencentric commented Sep 26, 2024

Pull request type

  • Build and release changes

What does this PR change?

Currently nothing, I want the CI to pass with minimal changes before doing anything else CI passed, so time for changes:

  • Drops 3.8 and adds 3.13 to the test matrix
  • Update all the GitHub actions to their latest versions
  • Replace old style strings with f-strings
  • Replace typing.List (and similar) with their standard equivalent
  • Upgrade aarch64 from ubuntu20.04+py39 to ubuntu22.04+py310.
  • Remove code paths that checked for python versions less than 3.9

@Ravencentric
Copy link
Contributor Author

@miurahr do you have any idea why the tests are failing? I'm sort of lost here since I made minimal changes?

@miurahr
Copy link
Owner

miurahr commented Sep 26, 2024

@miurahr do you have any idea why the tests are failing? I'm sort of lost here since I made minimal changes?

#611 fix the typo not only document but variable name. It enabled the previous dead code, which cause the behavior change, and raised the bug.

I remove the problematic line in the latest branch commit. Could you rebase the PR on the latest master?

@miurahr
Copy link
Owner

miurahr commented Sep 27, 2024

uraimo/run-on-arch-action@v2 is failed

@Ravencentric
Copy link
Contributor Author

uraimo/run-on-arch-action@v2 is failed

Yep, working on a fix right now

@Ravencentric
Copy link
Contributor Author

@miurahr I think this PR is done and ready for review

@miurahr miurahr self-requested a review September 27, 2024 23:42
@miurahr miurahr merged commit f10dcb5 into miurahr:master Sep 27, 2024
24 checks passed
@Ravencentric Ravencentric deleted the py313 branch September 28, 2024 05:33
miurahr added a commit that referenced this pull request Sep 29, 2024
- Add changes in #619
- Move old log into previous_changes.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants