Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version of PR #350 #359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated version of PR #350 #359

wants to merge 1 commit into from

Conversation

yusing
Copy link

@yusing yusing commented Oct 6, 2024

Improved version of closed PR #350

  • Added GitHub Workflow, now can build docker image and push to ghcr on new tag is pushed
  • Added Support for self-signed certs for API endpoints
  • Updated dockerfile and docker compose for a production build instead of running in dev mode
  • Updated docker compose to use ghcr image
  • Updated bun lock file to match package.json, for building docker image with bun install --frozen-lockfile
  • Removed '6379:6379' port mapping for redis, since there's no reason to map redis to host
  • Removed searxng_data:/data mount for searxng, since there's no such mountpoint on official searxng's docker compose
  • Refactored changed docker-compose.yaml to compose.yml since docker offcially suggest using the latter

It's tested and running great
{519692A0-CBDE-4403-B09B-0299EAB574DC}

build production build instead of dev
GitHub Action support
Copy link

vercel bot commented Oct 6, 2024

Someone is attempting to deploy a commit to the morphic Team on Vercel.

A member of the Team first needs to authorize it.

@yusing yusing changed the title updated dockerfile and compose Updated version of PR #350 Oct 6, 2024
@casistack
Copy link
Contributor

casistack commented Oct 7, 2024

Yes that looks good . The volume was added more for the dev to have a persistent storage in the container and its
discretionary. Ports etc all entirely up to devs as people might have different environments for testing.

@yusing
Copy link
Author

yusing commented Oct 7, 2024

Got it. If merge isn't possible feel free to just copy what you think is useful.

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
morphic ❌ Failed (Inspect) Oct 12, 2024 8:53am

@miurla
Copy link
Owner

miurla commented Oct 12, 2024

@yusing
Thank you for creating the PR again. There's still a build error. You should be able to check it with the bun run build
I've updated the bun.lockb in morphic/main, could you please merge it?

[17:52:38.836] Running "bun run build"
[17:52:38.842] $ next build
[17:52:39.597]   ▲ Next.js 14.2.13
[17:52:39.598] 
[17:52:39.681]    Creating an optimized production build ...
[17:53:14.015]  ✓ Compiled successfully
[17:53:14.016]    Linting and checking validity of types ...
[17:53:24.150] Failed to compile.
[17:53:24.151] 
[17:53:24.151] ./components/ui/codeblock.tsx:60:36
[17:53:24.151] Type error: This kind of expression is always truthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants