Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: make plot call in network function optional #145

Closed
wgervasio opened this issue Aug 9, 2021 · 2 comments · Fixed by #201
Closed

feature request: make plot call in network function optional #145

wgervasio opened this issue Aug 9, 2021 · 2 comments · Fixed by #201
Assignees
@Max-Bladen
Labels
enhancement-request New feature or request

Comments

@wgervasio
Copy link

Description of what the problem is. Ex. I'm always frustrated when [...]
Whenever I want to work on the network graphs, R plots it automatically. This can be troublesome when displaying further processed results in Shiny as an example.

Describe the solution you'd like
add a boolean to the network args to turn off plotting
@wgervasio wgervasio added the feature-request Can be implemented if there's enough interest label Aug 9, 2021
@Max-Bladen Max-Bladen assigned Max-Bladen and unassigned aljabadi Mar 14, 2022
@Max-Bladen Max-Bladen added the wip work-in-progress label Mar 29, 2022
Max-Bladen added a commit that referenced this issue Mar 29, 2022
@Max-Bladen
Enhancement for Issue #145
b62c53c
@Max-Bladen Max-Bladen removed the wip work-in-progress label Mar 29, 2022
@Max-Bladen Max-Bladen linked a pull request Mar 29, 2022 that will close this issue
Enhancement for #145 #201
Merged
Max-Bladen added a commit that referenced this issue Apr 3, 2022
@Max-Bladen
Enhancement for #145. Doc Commit
8e09a5d 
fix(documentation): added the `plot.graph` parameter to `network()` documentation
Max-Bladen added a commit that referenced this issue Apr 3, 2022
@Max-Bladen
Enhancement for #145. Test commit
b4ac34a 
test(network): added test for ensure that numerical output of `network()` remains stable irrespective of `plot.graph` parameter
@Max-Bladen
Copy link
Collaborator

Hi @wgervasio,

I've implemented your requested enhancement. You can access it using the following commands in R:

devtools::install_github("mixOmicsTeam/mixOmics", ref = github_pull("201"))

Please let me know if you notice any issues

@wgervasio
Copy link
Author

Works fine on my end! It solves an issue I had with a Shiny app for quite a while :)

Max-Bladen added a commit that referenced this issue Sep 22, 2022
@Max-Bladen
Enhancement for #145 (#201)
4940737 
feat: added `plot.graph` parameter to network to allow user control over whether to plot the network or just return the output. Either way, the returned object is the same
@Max-Bladen Max-Bladen added enhancement-request New feature or request and removed feature-request Can be implemented if there's enough interest labels Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Max-Bladen Max-Bladen

Labels
enhancement-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement for #145 mixOmicsTeam/mixOmics
3 participants
@aljabadi @Max-Bladen @wgervasio